Skip to content

Conversation

@nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling [email protected]

@nickvergessen nickvergessen added this to the Nextcloud 18 milestone Dec 5, 2019
@nickvergessen nickvergessen requested a review from rullzer December 5, 2019 13:43
@nickvergessen
Copy link
Member Author

Before installation failed on oracle:
https://travis-ci.org/nextcloud/notifications/jobs/621104031#L1359

$table->setPrimaryKey(['id']);

// Quite radical, we just assume no one updates cross beta with a pending request.
// Do not try this at home
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@rullzer rullzer force-pushed the bugfix/noid/broken-oracle-install branch 2 times, most recently from e785eb1 to 5468358 Compare December 10, 2019 08:13
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer force-pushed the bugfix/noid/broken-oracle-install branch from 5468358 to 059968e Compare December 10, 2019 10:01
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 10, 2019
@rullzer rullzer merged commit c9d77b7 into master Dec 10, 2019
@rullzer rullzer deleted the bugfix/noid/broken-oracle-install branch December 10, 2019 12:28
@rullzer rullzer mentioned this pull request Dec 11, 2019
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: install and update regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants