Skip to content

Add autocompletion to the ownership transfer UI #18293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Dec 10, 2019
Merged

Add autocompletion to the ownership transfer UI #18293

rullzer merged 1 commit into from
Dec 10, 2019

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 9, 2019 •
edited
Loading

Fixes #18273
Fixes #18274

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Dec 9, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Dec 9, 2019
@ChristophWurst ChristophWurst self-assigned this Dec 9, 2019
@ChristophWurst ChristophWurst marked this pull request as ready for review December 9, 2019 11:58
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 9, 2019
rullzer
rullzer approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the trick. 🚀

georgehrke
georgehrke previously requested changes Dec 10, 2019
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if there was a spinner when loading the users.

Multiselect is offering a loading prop :)

@ChristophWurst ChristophWurst force-pushed the feature/transfer-ownership-autocompletion branch from 6d62992 to 146732f Compare December 10, 2019 11:49
@rullzer rullzer merged commit 5aacb43 into master Dec 10, 2019
@rullzer rullzer deleted the feature/transfer-ownership-autocompletion branch December 10, 2019 14:28
@rullzer rullzer mentioned this pull request Dec 11, 2019
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@georgehrke georgehrke georgehrke left review comments

@wiswedel wiswedel Awaiting requested review from wiswedel

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@ChristophWurst ChristophWurst

Labels

3. to review Waiting for reviews enhancement feature: files feature: users and groups

Projects

None yet

Milestone

Nextcloud 18.0.0

4 participants

@ChristophWurst @rullzer @georgehrke