Design fixes for recommended apps #18422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jancborchardt
added
bug
design
8 tasks
ChristophWurst
requested changes
Dec 16, 2019
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Screenshots looks good
Bundle was not updated
Member
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
design/recommended-apps
branch
from
3589582 to
f70755e
Compare
rullzer
force-pushed
the
design/recommended-apps
branch
from
f70755e to
2ebfdcf
Compare
Member
|
/compile amend / |
Signed-off-by: Jan-Christoph Borchardt <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
design/recommended-apps
branch
from
2ebfdcf to
418896f
Compare
Member
Author
|
@rullzer from what I can tell, the Drone failures are unrelated? |
Member
Author
|
Also thanks to @gary-kim for the in-person review! :) Feel free to check the code if you like |
rullzer
approved these changes
Dec 17, 2019
ChristophWurst
approved these changes
Dec 17, 2019
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Fix #18363, please review @ChristophWurst @rullzer @juliushaertl