Skip to content

Fix/noid/double flow #18430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Dec 16, 2019
Merged

Fix/noid/double flow #18430

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea7294f
do not add (user) flows twice
blizzz Dec 16, 2019
8b18b0c
lower to debug, since we fire two events, so it is legitimate
blizzz Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
do not add (user) flows twice 
Signed-off-by: Arthur Schiwon <[email protected]>
  • Loading branch information
@blizzz
blizzz committed Dec 16, 2019
commit ea7294f7d5b1ca9baf798a5457a97a2d04598a43
2 changes: 1 addition & 1 deletion apps/workflowengine/lib/Service/RuleMatcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public function getMatchingOperations(string $class, bool $returnFirstMatchingOp
$additionalScopes = $this->manager->getAllConfiguredScopesForOperation($class);
foreach ($additionalScopes as $hash => $scopeCandidate) {
/** @var ScopeContext $scopeCandidate */
if ($scopeCandidate->getScope() !== IManager::SCOPE_USER) {
if ($scopeCandidate->getScope() !== IManager::SCOPE_USER || in_array($scopeCandidate, $scopes)) {
continue;
}
if ($this->entity->isLegitimatedForUserId($scopeCandidate->getScopeId())) {
Expand Down