Skip to content

Conversation

@ChristophWurst
Copy link
Member

Files will still change until the 18 final, but this brings us closer to correct author comments.

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Dec 19, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Dec 19, 2019
@ChristophWurst ChristophWurst self-assigned this Dec 19, 2019
@kesselb
Copy link
Contributor

kesselb commented Dec 19, 2019

Is the license headers script able to parse the mailmap? In that case we should probably map

@juliusknorr
Copy link
Member

Is the license headers script able to parse the mailmap ? In that case we should probably map

Yes, sould work: https://github.com/nextcloud/server/blob/master/build/license.php#L355

@ChristophWurst
Copy link
Member Author

Updated the script to exclude these special github users. Will push once the run is done (this scrip is slooooooooooooow)

@kesselb
Copy link
Contributor

kesselb commented Dec 19, 2019

Updated the script to exclude these special github users. Will push once the run is done (this scrip is slooooooooooooow)

Fine by me but they are not so special. You can use them to hide your real mail address. I would rather put them to mailmap for those cases.

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 19, 2019
@kesselb
Copy link
Contributor

kesselb commented Dec 19, 2019

Hmm. You removed some people now. They are probably sad. Please consider to update the mailmap accordingly and include them again.

@rullzer rullzer mentioned this pull request Dec 19, 2019
18 tasks
@ChristophWurst
Copy link
Member Author

Hmm. You removed some people now. They are probably sad. Please consider to update the mailmap accordingly and include them again.

It's hard. Because some of these noreply addresses are from review change suggestions

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst merged commit 35c2a9f into master Dec 20, 2019
@ChristophWurst ChristophWurst deleted the fix/license-headers-18 branch December 20, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants