Skip to content

Various flow related fixes #18547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 6 commits into from
Dec 27, 2019
Merged

Various flow related fixes #18547

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8779ee
Allow selecting other event types (fix #18510)
juliusknorr Dec 23, 2019
dca861d
Fix app store link and hide it for users (fix #18495 #18500)
juliusknorr Dec 23, 2019
e7ad044
Validate check array in the backend
juliusknorr Dec 23, 2019
8ec66d1
Autofocus new filter and display proper error messages
juliusknorr Dec 23, 2019
5f3e3ae
Fix spacing between text and icon
juliusknorr Dec 23, 2019
b2ba561
Bump workflowengine bundles
juliusknorr Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Validate check array in the backend 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
  • Loading branch information
@juliusknorr
juliusknorr committed Dec 27, 2019
commit e7ad0448261a6706053749ea7eaf4c34ddef17ef
7 changes: 7 additions & 0 deletions apps/workflowengine/lib/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,9 +467,16 @@ public function validateOperation($class, $name, array $checks, $operation, stri

$this->validateEvents($entity, $events, $instance);

if (count($checks) === 0) {
throw new \UnexpectedValueException($this->l->t('At least one check needs to be provided'));
}
$instance->validateOperation($name, $checks, $operation);

foreach ($checks as $check) {
if (!is_string($check['class'])) {
throw new \UnexpectedValueException($this->l->t('Invalid check provided'));
}

try {
/** @var ICheck $instance */
$instance = $this->container->query($check['class']);
Expand Down