-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add OCA.Files.Settings for Files navigation settings #18556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| <!-- | ||
| - @copyright Copyright (c) 2020 Gary Kim <[email protected]> | ||
| - | ||
| - @author Gary Kim <[email protected]> | ||
| - | ||
| - @license GNU AGPL version 3 or any later version | ||
| - | ||
| - This program is free software: you can redistribute it and/or modify | ||
| - it under the terms of the GNU Affero General Public License as | ||
| - published by the Free Software Foundation, either version 3 of the | ||
| - License, or (at your option) any later version. | ||
| - | ||
| - This program is distributed in the hope that it will be useful, | ||
| - but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| - GNU Affero General Public License for more details. | ||
| - | ||
| - You should have received a copy of the GNU Affero General Public License | ||
| - along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| - | ||
| --> | ||
|
|
||
| <template> | ||
| <div /> | ||
| </template> | ||
| <script> | ||
| export default { | ||
| name: 'Setting', | ||
| props: { | ||
| el: { | ||
| type: Function, | ||
| required: true, | ||
| } | ||
| }, | ||
| mounted() { | ||
| this.$el.appendChild(this.el()) | ||
| } | ||
| } | ||
| </script> | ||
| <style> | ||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /** | ||
| * @copyright Copyright (c) 2019 Gary Kim <[email protected]> | ||
| * @copyright Copyright (c) 2019 John Molakvoæ <[email protected]> | ||
| * | ||
| * @author Gary Kim <[email protected]> | ||
| * | ||
| * @license GNU AGPL version 3 or any later version | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as | ||
| * published by the Free Software Foundation, either version 3 of the | ||
| * License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| * | ||
| */ | ||
|
|
||
| import Vue from 'vue' | ||
| import Settings from './services/Settings' | ||
| import SettingsView from './views/Settings' | ||
| import Setting from './models/Setting' | ||
|
|
||
| Vue.prototype.t = t | ||
|
|
||
| // Init Files App Settings Service | ||
| if (!window.OCA.Files) { | ||
| window.OCA.Files = {} | ||
| } | ||
| Object.assign(window.OCA.Files, { Settings: new Settings() }) | ||
| Object.assign(window.OCA.Files.Settings, { Setting }) | ||
|
|
||
| window.addEventListener('DOMContentLoaded', () => { | ||
| // Init Vue app | ||
| // eslint-disable-next-line | ||
| new Vue({ | ||
| el: '#files-app-settings', | ||
| render: h => h(SettingsView), | ||
| }) | ||
|
|
||
| const appSettingsHeader = document.getElementById('app-settings-header') | ||
| if (appSettingsHeader) { | ||
| appSettingsHeader.addEventListener('click', e => { | ||
| const opened = e.currentTarget.children[0].classList.contains('opened') | ||
| OCA.Files.Settings.settings.forEach(e => opened ? e.close() : e.open()) | ||
| }) | ||
| } | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /** | ||
| * @copyright Copyright (c) 2019 Gary Kim <[email protected]> | ||
| * @copyright Copyright (c) 2019 John Molakvoæ <[email protected]> | ||
| * | ||
| * @author Gary Kim <[email protected]> | ||
| * | ||
| * @license GNU AGPL version 3 or any later version | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as | ||
| * published by the Free Software Foundation, either version 3 of the | ||
| * License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| * | ||
| */ | ||
|
|
||
| export default class Setting { | ||
|
|
||
| #close | ||
| #el | ||
| #name | ||
| #open | ||
|
|
||
| /** | ||
| * Create a new files app setting | ||
| * | ||
| * @since 19.0.0 | ||
| * @param {string} name the name of this setting | ||
| * @param {Function} component.el function that returns an unmounted dom element to be added | ||
| * @param {Function} [component.open] callback for when setting is added | ||
| * @param {Function} [component.close] callback for when setting is closed | ||
| */ | ||
| constructor(name, { el, open, close }) { | ||
| this.#name = name | ||
| this.#el = el | ||
| this.#open = open | ||
| this.#close = close | ||
| if (typeof this.#open !== 'function') { | ||
| this.#open = () => {} | ||
| } | ||
| if (typeof this.#close !== 'function') { | ||
| this.#close = () => {} | ||
| } | ||
| } | ||
|
|
||
| get name() { | ||
| return this.#name | ||
| } | ||
|
|
||
| get el() { | ||
| return this.#el | ||
| } | ||
|
|
||
| get open() { | ||
| return this.#open | ||
| } | ||
|
|
||
| get close() { | ||
| return this.#close | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /** | ||
| * @copyright Copyright (c) 2019 Gary Kim <[email protected]> | ||
| * | ||
| * @author Gary Kim <[email protected]> | ||
| * | ||
| * @license GNU AGPL version 3 or any later version | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as | ||
| * published by the Free Software Foundation, either version 3 of the | ||
| * License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| * | ||
| */ | ||
|
|
||
| export default class Settings { | ||
|
|
||
| #settings | ||
|
|
||
| constructor() { | ||
| this.#settings = [] | ||
| console.debug('OCA.Files.Settings initialized') | ||
| } | ||
|
|
||
| /** | ||
| * Register a new setting | ||
| * | ||
| * @since 19.0.0 | ||
| * @param {OCA.Files.Settings.Setting} view element to add to settings | ||
| * @returns {boolean} whether registering was successful | ||
| */ | ||
| register(view) { | ||
| if (this.#settings.filter(e => e.name === view.name).length > 0) { | ||
| console.error('A setting with the same name is already registered') | ||
| return false | ||
| } | ||
| this.#settings.push(view) | ||
| return true | ||
| } | ||
|
|
||
| /** | ||
| * All settings elements | ||
| * @returns {OCA.Files.Settings.Setting[]} All currently registered settings | ||
| */ | ||
| get settings() { | ||
| return this.#settings | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <!-- | ||
| - @copyright Copyright (c) 2019 Gary Kim <[email protected]> | ||
| - | ||
| - @author Gary Kim <[email protected]> | ||
| - | ||
| - @license GNU AGPL version 3 or any later version | ||
| - | ||
| - This program is free software: you can redistribute it and/or modify | ||
| - it under the terms of the GNU Affero General Public License as | ||
| - published by the Free Software Foundation, either version 3 of the | ||
| - License, or (at your option) any later version. | ||
| - | ||
| - This program is distributed in the hope that it will be useful, | ||
| - but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| - GNU Affero General Public License for more details. | ||
| - | ||
| - You should have received a copy of the GNU Affero General Public License | ||
| - along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| - | ||
| --> | ||
| <template> | ||
| <div id="files-app-extra-settings"> | ||
| <template v-for="setting in settings"> | ||
| <Setting :el="setting.el" :key="setting.name" /> | ||
| </template> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script> | ||
| import Setting from '../components/Setting' | ||
|
|
||
| export default { | ||
| name: 'Settings', | ||
| components: { | ||
| Setting | ||
| }, | ||
| data() { | ||
| return { | ||
| settings: OCA.Files.Settings.settings | ||
| } | ||
| } | ||
| } | ||
| </script> | ||
|
|
||
| <style lang="scss" scoped> | ||
|
|
||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.