Skip to content

enable option '--no-interaction' for db:convert-type #18576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 2 commits into from
Jan 7, 2020
Merged

enable option '--no-interaction' for db:convert-type #18576

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe0e47b
enable option '--no-interaction' for db:convert-type
BernieO Dec 27, 2019
6a017eb
Introduce new variable with the default answer to allow option --no-i…
BernieO Dec 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Introduce new variable with the default answer to allow option --no-i… 
…nteraction for command occ db:convert-type

Variable is set to true for --no-interaction and false otherwise

Signed-off-by: Bernhard Ostertag <[email protected]>
  • Loading branch information
@BernieO
BernieO committed Dec 29, 2019
commit 6a017eb205c6c37d01d76495e2084f5e1ff4fd17
14 changes: 7 additions & 7 deletions core/Command/Db/ConvertType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,14 @@ protected function execute(InputInterface $input, OutputInterface $output) {
$output->writeln('<comment>can be included by specifying the --all-apps option.</comment>');
}

if ($input->isInteractive()) {
/** @var QuestionHelper $helper */
$helper = $this->getHelper('question');
$question = new ConfirmationQuestion('Continue with the conversion (y/n)? [n] ', false);
$continueConversion = !$input->isInteractive(); // assume yes for --no-interaction and no otherwise.
$question = new ConfirmationQuestion('Continue with the conversion (y/n)? [n] ', $continueConversion);

if (!$helper->ask($input, $output, $question)) {
return;
}
/** @var QuestionHelper $helper */
$helper = $this->getHelper('question');

if (!$helper->ask($input, $output, $question)) {
return;
}
}
$intersectingTables = array_intersect($toTables, $fromTables);
Expand Down