Do not show e-mail suggestions if link shares are disabled #18675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
ChristophWurst,
gary-kim,
juliusknorr,
kesselb and
skjnldsv
Member
|
/compile amend / EDIT: Aaannddd, nothing... |
gary-kim
force-pushed
the
fix/17774/no_email_suggestions_when_linkshare_disabled
branch
from
f20548c to
2dd11de
Compare
skjnldsv
approved these changes
Jan 6, 2020
For #17774 This removes the e-mail suggestions from the share input if link shares are disabled. As e-mail shares use just link shares. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
fix/17774/no_email_suggestions_when_linkshare_disabled
branch
from
2dd11de to
9a8b361
Compare
gary-kim
added
4. to release
rullzer
deleted the
fix/17774/no_email_suggestions_when_linkshare_disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #17774
This removes the e-mail suggestions from the share input if link shares
are disabled. As e-mail shares use just link shares.
Signed-off-by: Roeland Jago Douma [email protected]