Accept shares when you open mail #18696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #18380 When you open a direct share to yourself. We should autoaccept the share. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
requested review from
ChristophWurst,
jancborchardt,
juliusknorr,
kesselb,
nickvergessen,
skjnldsv,
tobiasKaminsky and
wiswedel
skjnldsv
approved these changes
Jan 6, 2020
wiswedel
approved these changes
Jan 6, 2020
Contributor
|
@rullzer Can we re-use this for nextcloud/guests#222 later? |
Member
Author
We'll do something similar yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18380
When you open a direct share to yourself. We should autoaccept the
share.
To test:
Before:
💥 since the share was not accepted leading to bad UX
Now: