A pending shares overview #18707
A pending shares overview #18707
Conversation
Now that we accept shares we should show an overview of shares that are pending. This first part is the small API to get a list of the currently pending shares. Signed-off-by: Roeland Jago Douma <[email protected]>
|
@rullzer Pushed a commit for the frontend part. For now I've added a separate "pending shares" list where the user can either accept or reject them. |
|
@juliushaertl mmm it isn't working for me... I don't see the request in the network tab as well.. |
juliusknorr
force-pushed
the
enh/pending_shares_overview
branch
from
1db494a to
87ea79a
Compare
|
Awesome! Only thing. The details and show in folder in the '...' are kind of broken now... |
juliusknorr
force-pushed
the
enh/pending_shares_overview
branch
from
87ea79a to
a3a510c
Compare
Fixed 😉 |
rullzer
added
3. to review
rullzer
requested review from
ChristophWurst,
gary-kim,
kesselb,
skjnldsv,
tobiasKaminsky and
wiswedel
|
@juliushaertl Can you provide a screenshot please? |
|
Behind "Name" is 123.txt, which is barely readable. |
|
(might be because of my test system, but I did not got any notification (red alarm bell)? |
Unrelated, please open a separate issue.
Do you have the notifications app enabled and did you wait for some time as the web ui just polls regularly for new notifications. |
This doesn't touch any notification code. |
|
👍 working otherwise |
:( I heard this often before … yes I guess it has to be done like this for lack of time, but I’m not happy as I doubt it will in fact be fixed for 19. The spec has been there for ages at #2192 |
If we schedule some time for that in 19, I think this should be doable with not to much effort. Just nothing we can implement properly 1 1/2 weeks before the actual release. |
I know what you mean. But the alternative is that we have nothing right now. ;) |
Signed-off-by: Julius Härtl <[email protected]> Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
enh/pending_shares_overview
branch
from
a3a510c to
445274c
Compare
|
Fixed the tests. |
rullzer
added
4. to release
Now that we accept shares we should show an overview of shares that are
pending. This first part is the small API to get a list of the currently
pending shares.
As noticed by @tobiasKaminsky
If you now press X on a share. It just doesn't show.
For now I would go for a new section in the sharing section. But for 19 we should look into unifying this with the deleted shares. @nextcloud/designers