Encode URI for file sidebar #18724
Merged
Encode URI for file sidebar #18724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Kim <[email protected]>
gary-kim
added
bug
3. to review
skjnldsv
approved these changes
Jan 7, 2020
kesselb
approved these changes
Jan 7, 2020
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
I have no idea but encoding seems the right thing ;)
gary-kim
added
4. to release
rullzer
approved these changes
Jan 7, 2020
ChristophWurst
approved these changes
Jan 7, 2020
Member
|
@gary-kim I'd better recommend escape() |
Contributor
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/escape |
Member
|
@kesselb oh okay, i didn't knew, i was just wondering if encoding |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18721
Something to add to my checklist of "things to check for when reviewing javascript code".
Signed-off-by: Gary Kim [email protected]