Trash bin: fix exception triggered if no correct fileId is provided.

[simonspa]

Somehow in some installations the trash bin preview controller is called with incorrect $fileId. By assigning a default value and catching the default, a BAD_REQUEST can be returned instead. This behavior is taken from the "normal" files preview controller.

This fixes #17115

[kesselb]

Thanks 👍

Could you try to rebase your patch with the latest changes from nextcloud/server? https://github.com/simonspa/server/tree/trashbin_exception is some commits behind hence the CI is failing. I'm usually do it like this: https://thoughtbot.com/blog/keeping-a-github-fork-updated

[simonspa]

@kesselb I somehow forgot to update my fork before adding the fix. Anyway, rebased now. Somehow some of the CI tests still fail. Do I need to take care of something else?

[rullzer]

Nice catch!

[ChristophWurst]

Alternatively we could have made it nullable, but fine by me 👍

Thanks :)

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

[simonspa]

Maybe this could also be backported for 17.0.3?

[rullzer]

/backport to stable17

[backportbot-nextcloud]

backport to stable17 in #18734