Skip to content

Do not rerender the selection menu on show #18753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Jan 8, 2020
Merged

Do not rerender the selection menu on show #18753

rullzer merged 1 commit into from
Jan 8, 2020

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 8, 2020

Steps to reproduce:

  1. Get a folder shared read only
  2. Select a file with the checkbox
  3. Open the selected actions menu

Before:

  • You see the delete option

After:

  • The delete option is properly hidden

@juliusknorr juliusknorr added this to the Nextcloud 18 milestone Jan 8, 2020
@juliusknorr
Copy link
Member Author

juliusknorr commented Jan 8, 2020

/backport to stable17

@juliusknorr
Copy link
Member Author

juliusknorr commented Jan 8, 2020

/backport to stable16

rullzer
rullzer approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure... 🐘

@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 8, 2020
@rullzer rullzer merged commit e046ed3 into master Jan 8, 2020
@rullzer rullzer deleted the bugfix/noid/select-menu-hide branch January 8, 2020 18:21
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 8, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 8, 2020

backport to stable17 in #18758

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 8, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 8, 2020

backport to stable16 in #18759

@rullzer rullzer mentioned this pull request Jan 9, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@tomasz-grobelny tomasz-grobelny Awaiting requested review from tomasz-grobelny

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug regression

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@juliusknorr @rullzer @ChristophWurst @skjnldsv @gary-kim