Skip to content

Combine exact and other matches for transfer ownership #18757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Jan 9, 2020
Merged

Combine exact and other matches for transfer ownership #18757

rullzer merged 1 commit into from
Jan 9, 2020

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 8, 2020 •
edited
Loading

Fixes #18624.

Before: only suggestions for partial matches. Exact matches don't work.
After: both work 🚀

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Jan 8, 2020
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Jan 8, 2020
@ChristophWurst ChristophWurst self-assigned this Jan 8, 2020
@ChristophWurst ChristophWurst force-pushed the fix/transfer-ownership-autocomplete-matching branch from d077135 to 78ee689 Compare January 8, 2020 18:45
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 8, 2020
@ChristophWurst ChristophWurst marked this pull request as ready for review January 8, 2020 18:46
rullzer
rullzer approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O jikes... good catch.

somehow this feels as something we should probably abstract away in a package somewhere ;)

@rullzer rullzer modified the milestones: Nextcloud 18, Nextcloud 19 Jan 9, 2020
@rullzer
Copy link
Member

rullzer commented Jan 9, 2020

master is NC19 now.
Please backport if it needs to go into 18

@wiswedel
Copy link
Contributor

wiswedel commented Jan 9, 2020

/backport to stable18

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 9, 2020
@rullzer rullzer merged commit 601718b into master Jan 9, 2020
@rullzer rullzer deleted the fix/transfer-ownership-autocomplete-matching branch January 9, 2020 10:07
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 9, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 9, 2020

backport to stable18 in #18769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@wiswedel wiswedel wiswedel approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

[Transfer ownership] Input field autocomplete unreliable

5 participants

@ChristophWurst @rullzer @wiswedel @skjnldsv