[stable16] relax strict getHome behaviour for LDAP users in a shadow state #18885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Jan 14, 2020
Merged
juliusknorr
approved these changes
Jan 23, 2020
juliusknorr
added
4. to release
Member
|
CI does boom |
juliusknorr
force-pushed
the
backport/17717/stable16
branch
from
86e7357 to
2a12d33
Compare
Member
|
Pushed a quick fix for PHPUnit compatibility |
Member
|
Doesn't seem to be enough https://drone.nextcloud.com/nextcloud/server/25471/14/4 |
This comment has been minimized.
This comment has been minimized.
blizzz
force-pushed
the
backport/17717/stable16
branch
from
2a12d33 to
f4a8881
Compare
* simplifies deletion process * less strange behaviour when looking up home storage (as long as it is local) * thus could enable transfer ownerships after user went invisible on ldap backport of #17717 Signed-off-by: Arthur Schiwon <[email protected]> decouple userExists from userExistsOnLDAP check allows to mark users as offline right away, avoids a gap of being not a user and causing weird side effects Signed-off-by: Arthur Schiwon <[email protected]> adjust tests Signed-off-by: Arthur Schiwon <[email protected]> remove superfluous tests - user_ldap is not exposed to public api, it is always behind ldap_proxy - this is too much for a unit test - integration tests cover userExists implicitly Signed-off-by: Arthur Schiwon <[email protected]> ensure that only valid group members are returned Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
backport/17717/stable16
branch
from
f4a8881 to
5c7948f
Compare
Member
Author
|
I added the unit test compat fixes from the17 backport #18884 |
Member
|
Greeeen |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #17717