Skip to content

Require to use at least desktop client 2.0 by default #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 3 commits into from
Oct 25, 2016
Merged

Require to use at least desktop client 2.0 by default #1913

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c39b30
Require to use at least desktop client 2.0 by default
DeepDiver1975 Oct 21, 2016
9df3869
Fix unit tests for BlockLegacyClientPlugin
DeepDiver1975 Oct 24, 2016
1f90949
Set 2.0.0 as minimum requirement for the desktop client in config.sam…
DeepDiver1975 Oct 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Require to use at least desktop client 2.0 by default
  • Loading branch information
@DeepDiver1975 @MorrisJobke
DeepDiver1975 authored and MorrisJobke committed Oct 25, 2016
commit 1c39b30d50ac70438bbb36e9318087c52a1f1c31
2 changes: 1 addition & 1 deletion apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function beforeHandler(RequestInterface $request) {
return;
}

$minimumSupportedDesktopVersion = $this->config->getSystemValue('minimum.supported.desktop.version', '1.7.0');
$minimumSupportedDesktopVersion = $this->config->getSystemValue('minimum.supported.desktop.version', '2.0.0');
Copy link
Member

@nickvergessen nickvergessen Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw sure we can allow people to require more up to date versions.
But should we have 2.0.0 as a minimum as well, so when someone copied sample.config.php he now still requires 2.0.0?

Copy link
Member

@rullzer rullzer Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we have no pacakges for all platforms lets just keep this as is :)


// Match on the mirall version which is in scheme "Mozilla/5.0 (%1) mirall/%2" or
// "mirall/%1" for older releases
Expand Down