Allow apps to provide Calendars in user's calendarHome #19196
Merged
+590
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgehrke
force-pushed
the
feature/17126/allow_apps_to_register_their_own_calendars
branch
from
a4ec37a to
47e661c
Compare
georgehrke
added
3. to review
Member
Author
|
CI looks good, just some random acceptance tests that failed. |
juliusknorr
reviewed
Jan 31, 2020
georgehrke
force-pushed
the
feature/17126/allow_apps_to_register_their_own_calendars
branch
from
47e661c to
21d8f0f
Compare
juliusknorr
approved these changes
Feb 1, 2020
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Code looks good and works great 👍
3 tasks
Signed-off-by: Georg Ehrke <[email protected]>
georgehrke
force-pushed
the
feature/17126/allow_apps_to_register_their_own_calendars
branch
from
21d8f0f to
b46e5cb
Compare
ChristophWurst
approved these changes
Feb 21, 2020
rullzer
deleted the
feature/17126/allow_apps_to_register_their_own_calendars
branch
Member
|
@georgehrke We need an update of the info.xml schema descriptions as well for the new |
Member
|
@georgehrke I suggest to do the same for contacts :) |
This was referenced Feb 27, 2020
ChristophWurst
added a commit
that referenced
this pull request
Mar 30, 2020
For #19795 For #19196 Ref nextcloud/appstore#673 Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added a commit
that referenced
this pull request
Mar 30, 2020
For #19795 For #19196 Ref nextcloud/appstore#673 Signed-off-by: Christoph Wurst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17126
Example implementation: https://github.com/georgehrke/davcalendardemo