Skip to content

Use the l10n from settings #19268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Feb 3, 2020
Merged

Use the l10n from settings #19268

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af8ad96
Use the l10n from settings
rullzer Feb 3, 2020
29fede5
Update test to pass l10n instead of factory
kesselb Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test to pass l10n instead of factory 
Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb committed Feb 3, 2020
commit 29fede5fe56c93fee4cffe5569d3c070e2423349
7 changes: 1 addition & 6 deletions apps/settings/tests/Settings/Admin/SharingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
use OCP\Constants;
use OCP\IConfig;
use OCP\IL10N;
use OCP\L10N\IFactory;
use OCP\Share\IManager;
use Test\TestCase;

Expand All @@ -52,15 +51,11 @@ protected function setUp(): void {
$this->config = $this->getMockBuilder(IConfig::class)->getMock();
$this->l10n = $this->getMockBuilder(IL10N::class)->getMock();

$l10Factory = $this->createMock(IFactory::class);
$l10Factory->method('get')
->willReturn($this->l10n);

$this->shareManager = $this->getMockBuilder(IManager::class)->getMock();

$this->admin = new Sharing(
$this->config,
$l10Factory,
$this->l10n,
$this->shareManager
);
}
Expand Down