Make TAG_FAVORITE public #19412
Merged
Make TAG_FAVORITE public #19412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
added
2. developing
Member
I'm a bit surprised constants are inherited as they are static properties of a class. But apparently PHP will allow you to access them via Let's use |
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
fix/19404/make-favorite-public
branch
from
768f68a to
6235175
Compare
Contributor
Author
|
Fine by me. |
ChristophWurst
approved these changes
Feb 12, 2020
juliusknorr
approved these changes
Feb 14, 2020
juliusknorr
added
4. to release
ChristophWurst
added a commit
to nextcloud/documentation
that referenced
this pull request
Apr 10, 2020
Ref nextcloud/server#19845 Ref nextcloud/server#19890 Ref nextcloud/server#19075 Ref nextcloud/server#19670 Ref nextcloud/server#19412 Ref nextcloud/server#14722 Ref nextcloud/server#19746 Ref nextcloud/server#19321 Ref nextcloud/server#19569 Signed-off-by: Christoph Wurst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19404
Actually PHPStorm did most of the work ;)
I need some advice regarding: https://github.com/nextcloud/server/pull/19412/files#diff-285a829dbb3541adc9e8ee65266f70aeR188 PHPStorm replaced
self::TAG_FAVORITEwithITags::TAG_FAVORITEinOC\Tags.OC\TagsimplementsITagshence the constants are available. Isself::CONSTANT_NAMEsome kind of anti pattern?