Skip to content

Remove gradient header for themed instances #19669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
earboxer wants to merge 2 commits into from
Closed

Remove gradient header for themed instances #19669

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c22d725
Fix header gradient (by removing it)
earboxer Feb 27, 2020
daba23b
Keep header gradient when using default theme color.
earboxer Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Keep header gradient when using default theme color.
  • Loading branch information
@earboxer
earboxer committed Mar 20, 2020
commit daba23be5ad90ebd6362f93eef69c9a45c31feab
3 changes: 3 additions & 0 deletions core/css/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
z-index: 2000;
height: $header-height;
background-color: var(--color-primary);
@if ($color-primary == #0082C9) {
background-image: linear-gradient(40deg, $color-primary 0%, lighten($color-primary, 20%) 100%);
Copy link
Member

@juliusknorr juliusknorr Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the default background image. That change should go to theming.scss. Maybe you can try something like this, to make sure that the gradient is properly set otherwise:

diff --git a/apps/theming/css/theming.scss b/apps/theming/css/theming.scss
index 0e9b922b27..c2a58dcc3d 100644
--- a/apps/theming/css/theming.scss
+++ b/apps/theming/css/theming.scss
@@ -8,7 +8,11 @@
 }
 
 @mixin faded-background {
-       background-image: linear-gradient(40deg, $color-primary 0%, lighten($color-primary, 20%) 100%);
+       @if ($color-primary == #0082C9) {
+               background-image: linear-gradient(40deg, $color-primary 0%, lighten($color-primary, 20%) 100%);
+       } @else {
+               background-color: $color-primary;
+       }
 }
 
 @mixin faded-background-image {
@@ -23,6 +27,10 @@
                @include faded-background;
                background-size: contain;
        }
+
+       @if ($color-primary != #0082C9) and ($has-custom-background == false) {
+               background-image: none;
+       }
 }

}
box-sizing: border-box;
justify-content: space-between;
}
Expand Down