Skip to content

silence LDAP deprecation logs in NC 18 #20274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Apr 2, 2020
Merged

silence LDAP deprecation logs in NC 18 #20274

rullzer merged 1 commit into from
Apr 2, 2020

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Apr 2, 2020

The proper fix for upcoming 19 is in #20037

Since that is too complex to backport, here, for 18, we just silence the message to avoid log flooding with PHP 7.4, fixing #19127

@blizzz blizzz added this to the Nextcloud 18.0.4 milestone Apr 2, 2020
@blizzz blizzz mentioned this pull request Apr 2, 2020
Closed
ChristophWurst
ChristophWurst approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

juliusknorr
juliusknorr approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@blizzz blizzz added the 4. to release Ready to be released and/or waiting for tests to finish label Apr 2, 2020
@rullzer rullzer merged commit 3c7e708 into stable18 Apr 2, 2020
@rullzer rullzer deleted the fix/19127/ldap-silence-deprecation-stable18 branch April 2, 2020 18:24
@j0hng0gu
Copy link

j0hng0gu commented Apr 8, 2020

Hi,

I also have this problem with php ldap error after upgrading to NC18 and PHP 7.4
I would like to aplly this patch/fix but i don't know how to do it. Can you please tell me? I don't see a download option here.

Many thanks!
John

@ChristophWurst
Copy link
Member

ChristophWurst commented Apr 8, 2020

https://github.com/nextcloud/server/pull/20274.patch

@j0hng0gu
Copy link

j0hng0gu commented Apr 8, 2020

Thank you very much, Christoph!

@rullzer rullzer mentioned this pull request Apr 13, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: ldap

Projects

None yet

Milestone

Nextcloud 18.0.4

Development

Successfully merging this pull request may close these issues.

6 participants

@blizzz @j0hng0gu @ChristophWurst @juliusknorr @rullzer