Skip to content

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Nov 8, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 10.0.2 milestone Nov 8, 2016
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer and @LukasReschke to be potential reviewers.

@MorrisJobke
Copy link
Member Author

There was 1 failure:
1) Test\Memcache\APCuTest::testDec
Failed asserting that -1 is false.
/drone/src/github.com/nextcloud/server/tests/lib/Memcache/Cache.php:90

This looks like this PHP7.0 breaking change - let me check the PR for master for this.

@MorrisJobke
Copy link
Member Author

To test on the current PHP 7 we should maybe backport #1227 and #1230 (otherwise APCu on PHP 7 is broken for stable10 🙈 ) - cc @karlitschek

@karlitschek
Copy link
Member

please backport 👍

This was referenced Nov 8, 2016
Fix an issue with APCus inc and dec methods on PHP 7

see krakjoe/apcu#183 (comment) for details

Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke force-pushed the stable10-update-containers branch from e82bd16 to 3f45794 Compare November 8, 2016 11:29
@nickvergessen
Copy link
Member

👍

@MorrisJobke MorrisJobke merged commit 9071fd5 into stable10 Nov 8, 2016
@MorrisJobke MorrisJobke deleted the stable10-update-containers branch November 8, 2016 13:37
@rockihack
Copy link

@MorrisJobke Call to undefined method OC\\LargeFileHelper::getFileSizeViaCOM() since 3f45794.

You forgot to remove the function call here:

$fileSize = $this->getFileSizeViaCOM($filename);

MorrisJobke added a commit that referenced this pull request Nov 24, 2016
* fixes #2048 (comment)

Signed-off-by: Morris Jobke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants