-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[stable10] Update containers to latest version #2048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer and @LukasReschke to be potential reviewers. |
This looks like this PHP7.0 breaking change - let me check the PR for master for this. |
|
To test on the current PHP 7 we should maybe backport #1227 and #1230 (otherwise APCu on PHP 7 is broken for stable10 🙈 ) - cc @karlitschek |
|
please backport 👍 |
Signed-off-by: Morris Jobke <[email protected]>
Fix an issue with APCus inc and dec methods on PHP 7 see krakjoe/apcu#183 (comment) for details Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
e82bd16 to
3f45794
Compare
|
👍 |
|
@MorrisJobke You forgot to remove the function call here: server/lib/private/LargeFileHelper.php Line 101 in f7a505d
|
* fixes #2048 (comment) Signed-off-by: Morris Jobke <[email protected]>
cc @rullzer @LukasReschke
see also #2047