Skip to content

Fix IE11 upload fallback methods #20595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Apr 22, 2020
Merged

Fix IE11 upload fallback methods #20595

skjnldsv merged 1 commit into from
Apr 22, 2020

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 22, 2020 •
edited
Loading

😡

https://developer.mozilla.org/en-US/docs/Web/API/FileReader/readAsBinaryString#Browser_compatibility

Steps:

  • Try uploading a file without extension, see an error without any more informations

@skjnldsv
Fix IE11 upload fallback methods
754fd40 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added this to the Nextcloud 19 milestone Apr 22, 2020
@skjnldsv skjnldsv self-assigned this Apr 22, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 22, 2020

/backport to stable18

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 22, 2020

/backport to stable17

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 22, 2020

/backport to stable16

MorrisJobke
MorrisJobke approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@nickvergessen
Copy link
Member

nickvergessen commented Apr 22, 2020

@ma12-co do we need this in talk too?

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 22, 2020

@ma12-co do we need this in talk too?

Now I'm afraid to look at the code you're using in talk 🙈

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 22, 2020
danxuliu
danxuliu approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

However, note that the problem was not in files without extension, but in files without extension, with size divisible by 4096 and smaller than 102400 bytes. How did you find this? xD

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 22, 2020

How did you find this? xD

I have my reasons xD

@skjnldsv skjnldsv merged commit d0a57a3 into master Apr 22, 2020
@skjnldsv skjnldsv deleted the fix/ie11-fallback-upload branch April 22, 2020 20:06
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 22, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Apr 22, 2020

backport to stable18 in #20602

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 22, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Apr 22, 2020

backport to stable17 in #20603

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 22, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Apr 22, 2020

backport to stable16 in #20604

@rullzer rullzer mentioned this pull request Apr 22, 2020
Merged
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@danxuliu danxuliu danxuliu approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv @nickvergessen @MorrisJobke @juliusknorr @danxuliu