Skip to content

Conversation

@MorrisJobke
Copy link
Member

No description provided.

@MorrisJobke MorrisJobke added this to the Nextcloud Next milestone Jun 23, 2016
@MorrisJobke
Copy link
Member Author

Woot

1) Test\DB\ConnectionTest::testSetValuesOverWrite
Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'INSERT INTO `oc_table` (`integerfield`, `textfield`) VALUES(?, ?)' with params [1, "bar"]:

SQLSTATE[HY000]: General error: 1364 Field 'clobfield' doesn't have a default value

/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:115
/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:116
/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:996
/drone/src/github.com/nextcloud/server/lib/private/DB/Connection.php:209
/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:208
/drone/src/github.com/nextcloud/server/lib/private/DB/QueryBuilder/QueryBuilder.php:141
/drone/src/github.com/nextcloud/server/lib/private/DB/Connection.php:280
/drone/src/github.com/nextcloud/server/tests/lib/DB/ConnectionTest.php:135

public function testSetValuesOverWrite() {
$this->makeTestTable();
$this->connection->setValues('table', [
'integerfield' => 1
], [
'textfield' => 'foo',
'clobfield' => 'not_null'
]);
$this->connection->setValues('table', [
'integerfield' => 1
], [
'textfield' => 'bar'
]);
$this->assertEquals('bar', $this->getTextValueByIntergerField(1));
}

@MorrisJobke
Copy link
Member Author

I have no idea why there is an insert instead of an update triggered.

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Jun 23, 2016

I just tested this with master@{2016-06-01} and it is also broken there. Somehow not an ConstraintViolationException is thrown but a DriverException that is not catched.

@MorrisJobke
Copy link
Member Author

Whaat?

1) Test\Files\Cache\CacheTest::testFolder with data set #2 ('😐, NEUTRAL_FACE, UTF-8 hex F09F9890')
Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'INSERT INTO `oc_filecache` (`size`,`mtime`,`mimepart`,`mimetype`,`path_hash`,`path`,`parent`,`name`,`storage`) SELECT ?,?,?,?,?,?,?,?,? FROM `oc_filecache` WHERE `storage` = ? AND `path_hash` = ? HAVING COUNT(*) = 0' with params [100, 50, "1", "2", "729b662513f13a316202fb5b7f62a62a", "\ud83d\ude10, NEUTRAL_FACE, UTF-8 hex F09F9890", -1, "\ud83d\ude10, NEUTRAL_FACE, UTF-8 hex F09F9890", "25", "25", "729b662513f13a316202fb5b7f62a62a"]:

SQLSTATE[HY000]: General error: 1366 Incorrect string value: '\xF0\x9F\x98\x90, ...' for column 'path' at row 1

/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:116
/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:116
/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:996
/drone/src/github.com/nextcloud/server/lib/private/DB/Connection.php:209
/drone/src/github.com/nextcloud/server/lib/private/DB/Adapter.php:113
/drone/src/github.com/nextcloud/server/lib/private/DB/Connection.php:247
/drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Cache.php:265
/drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Cache.php:220
/drone/src/github.com/nextcloud/server/tests/lib/Files/Cache/CacheTest.php:118

Caused by
Doctrine\DBAL\Driver\PDOException: SQLSTATE[HY000]: General error: 1366 Incorrect string value: '\xF0\x9F\x98\x90, ...' for column 'path' at row 1

/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:93
/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:989
/drone/src/github.com/nextcloud/server/lib/private/DB/Connection.php:209
/drone/src/github.com/nextcloud/server/lib/private/DB/Adapter.php:113
/drone/src/github.com/nextcloud/server/lib/private/DB/Connection.php:247
/drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Cache.php:265
/drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Cache.php:220
/drone/src/github.com/nextcloud/server/tests/lib/Files/Cache/CacheTest.php:118

Caused by
PDOException: SQLSTATE[HY000]: General error: 1366 Incorrect string value: '\xF0\x9F\x98\x90, ...' for column 'path' at row 1

/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:91
/drone/src/github.com/nextcloud/server/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:989
/drone/src/github.com/nextcloud/server/lib/private/DB/Connection.php:209
/drone/src/github.com/nextcloud/server/lib/private/DB/Adapter.php:113
/drone/src/github.com/nextcloud/server/lib/private/DB/Connection.php:247
/drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Cache.php:265
/drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Cache.php:220
/drone/src/github.com/nextcloud/server/tests/lib/Files/Cache/CacheTest.php:118

@LukasReschke
Copy link
Member

LGTM, let's get in some more testing.

@MorrisJobke
Copy link
Member Author

👍 (as this is administrative only)

@MorrisJobke MorrisJobke merged commit 444e95a into master Jun 30, 2016
@MorrisJobke MorrisJobke deleted the ci-mysql branch June 30, 2016 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants