Skip to content

Set etag for capabilities endpoint #20722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
May 4, 2020
Merged

Set etag for capabilities endpoint #20722

MorrisJobke merged 1 commit into from
May 4, 2020

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Apr 29, 2020

No description provided.

@kesselb kesselb added this to the Nextcloud 19 milestone Apr 29, 2020
@kesselb kesselb linked an issue Apr 29, 2020 that may be closed by this pull request
Enhance caching capabilities for capabilities-endpoint #20693
Closed
@kesselb
Set etag for capabilities endpoint
df669a2 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the enh/20693/etag-capabilities branch from bdbd05a to df669a2 Compare April 29, 2020 13:27
@rullzer rullzer mentioned this pull request Apr 29, 2020
Merged
11 tasks
@stefan-niedermann stefan-niedermann mentioned this pull request Apr 29, 2020
Closed
@rullzer rullzer modified the milestones: Nextcloud 19, Nextcloud 20 Apr 30, 2020
@rullzer
Copy link
Member

rullzer commented Apr 30, 2020

Lets do this early in 20. And then we make it nice and solid

@rullzer rullzer modified the milestones: Nextcloud 20, Nextcloud 19 May 2, 2020
@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 2, 2020
@rullzer rullzer mentioned this pull request May 2, 2020
Merged
2 tasks
@rullzer rullzer requested a review from nickvergessen May 3, 2020 12:30
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 4, 2020
@MorrisJobke
Copy link
Member

MorrisJobke commented May 4, 2020

@rullzer You said "Move to 20" but you changed the milestone to 19? Merge or no merge?

@MorrisJobke
Copy link
Member

MorrisJobke commented May 4, 2020

@rullzer You said "Move to 20" but you changed the milestone to 19? Merge or no merge?

He commented in chat, that he was thinking of a more general way, but as this is a trivial change and helps the clients, we can get it in now.

@MorrisJobke MorrisJobke merged commit a93d182 into master May 4, 2020
@MorrisJobke MorrisJobke deleted the enh/20693/etag-capabilities branch May 4, 2020 08:22
@stefan-niedermann
Copy link
Member

stefan-niedermann commented May 4, 2020

Thanks everybody :)

@kesselb kesselb mentioned this pull request May 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@georgehrke georgehrke Awaiting requested review from georgehrke

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

Enhance caching capabilities for capabilities-endpoint

6 participants

@kesselb @rullzer @MorrisJobke @stefan-niedermann @ChristophWurst