Fix expiry datepicker allowing all dates #20762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
reviewed
May 1, 2020
skjnldsv
reviewed
May 1, 2020
gary-kim
force-pushed
the
fix/20538/date-not-disabled
branch
from
b468eac to
09c5dd5
Compare
skjnldsv
reviewed
May 1, 2020
gary-kim
force-pushed
the
fix/20538/date-not-disabled
branch
2 times, most recently
from
5e02023 to
f1b1e23
Compare
skjnldsv
reviewed
May 2, 2020
gary-kim
force-pushed
the
fix/20538/date-not-disabled
branch
from
f1b1e23 to
4ecb1f4
Compare
skjnldsv
reviewed
May 2, 2020
skjnldsv
reviewed
May 2, 2020
vue2-datepicker expects a `disabled-date` function rather than `not-before` and `not-after` dates. This commit updates it so that we now provide vue2-datepicker with a `disabled-date` function. Signed-off-by: Gary Kim <[email protected]>
gary-kim
force-pushed
the
fix/20538/date-not-disabled
branch
from
4ecb1f4 to
8dd23f9
Compare
skjnldsv
approved these changes
May 2, 2020
rullzer
approved these changes
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vue2-datepicker expects a
disabled-datefunctionrather than
not-beforeandnot-afterdates.This commit updates it so that we now provide
vue2-datepicker with a
disabled-datefunction.Follow up to #20538
Signed-off-by: Gary Kim [email protected]