Apply Argon2 options for Argon2id hashing as well #20767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MichaIng <[email protected]>
rullzer
approved these changes
May 1, 2020
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
I think if argon2id is there argon2i is also there but still
Contributor
Yes. But that's probably not true the other way around :) |
Member
sure but that is fine. If i is there (as in the original check) then all is already good. But doesn't hurt to be sure |
Member
Author
Very likely, however now we are failsafe in case Argon2i is dropped in the feature or somehow disabled in certain circumstances. |
Member
|
Exactly hence my approval :D |
skjnldsv
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check and apply Argon2 settings from config.php in case of Argon2i hashing. Since NC19 Argon2id hashing is used, when available, which uses the same settings, hence we should apply them for Argon2id as well: #20710 (comment)
To be sure, the minimum values could be retested for Argon2id explicitly: #19023 (comment)