Improve group queries #20776
Merged
Improve group queries #20776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
May 1, 2020
Before we'd also get the diplayname for each group in the backend. In a separate query. This is of course not ideal as this information is obtained on each and every query. Now this is queried once and properly cached. Also added more caching to the manager. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
enh/limit_group_queries
branch
from
cf5eb75 to
5ebb535
Compare
rullzer
added
3. to review
rullzer
requested review from
ChristophWurst,
MorrisJobke,
danxuliu,
icewind1991,
kesselb and
nickvergessen
Member
|
I guess this one here solves already part of the issue: #20815 |
Member
Author
| $this->groupCache[$row['gid']] = $row['gid']; | ||
| $this->groupCache[$row['gid']] = [ | ||
| 'gid' => $row['gid'], | ||
| 'displayname' => $row['displayname'], |
Member
There was a problem hiding this comment.
it this always displayname? I had this issue in Mail recently and I went for selectAlias to ensure the database does not return the selected column, like g.displayname
Member
Author
There was a problem hiding this comment.
but there is only 1 displayname... so it should not prefix it right?
Member
Author
|
One more review please :) |
juliusknorr
approved these changes
May 22, 2020
Member
|
php-cs check failure seems unrelated to that change 😉 |
juliusknorr
added
4. to release
Member
Author
|
I guess a backport makes sense here. At least to stable19 for 19.0.1 |
Member
Author
|
/backport to stable19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we'd also get the diplayname for each group in the backend. In a
separate query. This is of course not ideal as this information is
obtained on each and every query. Now this is queried once and properly
cached.
Also added more caching to the manager.
Signed-off-by: Roeland Jago Douma [email protected]