Skip to content

Apply patch for scssphp #20794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
May 4, 2020
Merged

Apply patch for scssphp #20794

MorrisJobke merged 1 commit into from
May 4, 2020

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented May 3, 2020 •
edited by MorrisJobke
Loading

@kesselb kesselb requested review from ChristophWurst and rullzer May 3, 2020 12:41
@kesselb kesselb added 3. to review Waiting for reviews bug labels May 3, 2020
@kesselb kesselb added this to the Nextcloud 19 milestone May 3, 2020
@rullzer rullzer mentioned this pull request May 4, 2020
Merged
2 tasks
@MorrisJobke
Copy link
Member

MorrisJobke commented May 4, 2020

@kesselb This is to fix the variable undefined log message for the SCSS compiler?

@kesselb
Copy link
Contributor Author

kesselb commented May 4, 2020

@kesselb This is to fix the variable undefined log message for the SCSS compiler?

I think so. At least on my instance they are gone.

MorrisJobke
MorrisJobke approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@kesselb @MorrisJobke
Apply patch for scssphp
7a7df07 
Signed-off-by: Daniel Kesselberg <[email protected]>
@MorrisJobke MorrisJobke force-pushed the bug/noid/scssphp-compiler-notice branch from 29b4246 to 7a7df07 Compare May 4, 2020 08:28
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 4, 2020
@MorrisJobke
Copy link
Member

MorrisJobke commented May 4, 2020

Waiting for CI now :)

@MorrisJobke MorrisJobke mentioned this pull request May 4, 2020
Closed
@MorrisJobke MorrisJobke merged commit afb12dd into master May 4, 2020
@MorrisJobke MorrisJobke deleted the bug/noid/scssphp-compiler-notice branch May 4, 2020 12:32
@MorrisJobke
Copy link
Member

MorrisJobke commented May 4, 2020

@kesselb Backport to stable18?

@MorrisJobke MorrisJobke mentioned this pull request May 4, 2020
Closed
@kesselb
Copy link
Contributor Author

kesselb commented May 4, 2020

@MorrisJobke up to you. I patched my instance and do not care about the integrity warning ;)

@MorrisJobke
Copy link
Member

MorrisJobke commented May 4, 2020

We should check if this fix the problems with PHP 7.4 it seems.

@MorrisJobke
Copy link
Member

MorrisJobke commented May 6, 2020

/backport to stable18

@timm2k
Copy link
Contributor

timm2k commented May 19, 2020 •
edited
Loading

Actually I can't find the backport to stable18. Seems to stuck somewhere...

@ChristophWurst
Copy link
Member

ChristophWurst commented May 19, 2020

/backport to stable18

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented May 19, 2020

The backport to stable18 failed. Please do this backport manually.

@Wotisrv
Copy link

Wotisrv commented Jun 10, 2020

The backport to stable18 failed. Please do this backport manually.

How to do?

@blizzz
Copy link
Member

blizzz commented Jun 18, 2020

in 18 it is under a different namespace (leafo/scssphp)

@Wotisrv
Copy link

Wotisrv commented Jun 18, 2020

Why do we have to do it manually? Perhaps a little bit more informasjon on would be very helpful.

@blizzz
Copy link
Member

blizzz commented Jun 18, 2020

Why do we have to do it manually? Perhaps a little bit more informasjon on would be very helpful.

It does not fit to the version in 18 series, so it is not possible to do it automatically. From playing around a bit earlier, it seems that it might not catch all the cases that cause this debug messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

7 participants

@kesselb @MorrisJobke @timm2k @ChristophWurst @Wotisrv @blizzz