Do not process the same FileInfo twice #20831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
May 5, 2020
skjnldsv
force-pushed
the
fix/sidebar-fileinfo-change
branch
from
ebce822 to
1b5072d
Compare
MorrisJobke
force-pushed
the
fix/sidebar-fileinfo-change
branch
from
1b5072d to
5ce7b17
Compare
Member
|
/compile amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
fix/sidebar-fileinfo-change
branch
from
5ce7b17 to
d37c5c3
Compare
go2sh
approved these changes
May 6, 2020
| }, | ||
| }, | ||
| beforeMount() { |
Contributor
There was a problem hiding this comment.
In theory, the beforeMount hook should not be used for data loading, because its not executed within SSR. To load data, the created hook should be used.
But it has no real implications here, just a tiny nitpick. ;-)
Member
|
/backport to stable19 |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #20771
Better fix, it seems to create some issues on some other browsers.
Do not trigger twice if the fileinfo changed is exactly the same.
Fix broken acceptance sharing tests