Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #20955

@rullzer rullzer added the 3. to review Waiting for reviews label May 15, 2020
@kklem0 kklem0 changed the title [stable17] [stable18] Proxy server could cache http response when it is not private [stable17] Proxy server could cache http response when it is not private May 15, 2020
@rullzer
Copy link
Member

rullzer commented May 18, 2020

The tests seem to fail

@kklem0
Copy link
Contributor

kklem0 commented May 18, 2020

Too much noises in the tests... But I did a quick look and they don't seem to be related.

@ChristophWurst
Copy link
Member

Bildschirmfoto von 2020-05-18 14-02-40

@kklem0
Copy link
Contributor

kklem0 commented May 18, 2020

Where is that from?
The 2nd commit already fixed the test.

@ChristophWurst
Copy link
Member

You fixed testChainability, but on the screenshot testCacheSeconds fails

@rullzer rullzer mentioned this pull request May 21, 2020
3 tasks
Signed-off-by: Clement Wong <[email protected]>
@kklem0 kklem0 force-pushed the backport/20955/stable17 branch from 8894738 to 5576986 Compare May 23, 2020 21:00
@kklem0
Copy link
Contributor

kklem0 commented May 23, 2020

You fixed testChainability, but on the screenshot testCacheSeconds fails

Fixed

@rullzer rullzer merged commit b23db65 into stable17 May 25, 2020
@rullzer rullzer deleted the backport/20955/stable17 branch May 25, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants