Fixes not allowed increasing of link share permissions #2100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following: 1. user0 shares folder with user1 (RO but with sharing permissions) 2. user1 shares by link 3. user1 send 'publicUpload=true' OCS request to the link share before this increased the permissions of the link share. Which should not happen. now: API reponds with an error that the permissions can't be increased. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
added
3. to review
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @schiessle and @icewind1991 to be potential reviewers. |
Member
|
👍 |
Member
|
Integration test for this please 🤕 |
Member
Author
|
Unit test fully cover this. (they did not before). Intergration test should be doable but not from a phone ;-) |
Signed-off-by: Roeland Jago Douma <[email protected]>
Member
Author
|
Happy now @nickvergessen 😉 |
Member
|
Tested and works 👍 |
MorrisJobke
added
4. to release
rullzer
added a commit
that referenced
this pull request
Nov 14, 2016
Backport of #2100 Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
added a commit
that referenced
this pull request
Nov 14, 2016
Backport of #2100 Signed-off-by: Roeland Jago Douma <[email protected]>
This was referenced Nov 14, 2016
rullzer
added a commit
that referenced
this pull request
Nov 15, 2016
Backport of #2100 Signed-off-by: Roeland Jago Douma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following:
curl -u user:pass -H 'OCS-APIREQUEST: true' http://<server>/ocs/v2.php/apps/files_sharing/api/v1/sharescurl -u user:pass -H 'OCS-APIREQUEST: true' http://<server>/ocs/v2.php/apps/files_sharing/api/v1/shares/<id> -X PUT -d 'publicUpload=truebefore this increased the permissions of the link share. Which should
not happen.
now: API reponds with an error that the permissions can't be increased.
CC: @LukasReschke @schiessle @nickvergessen @MorrisJobke