Do not read certificate bundle from data dir by default #21090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
ChristophWurst,
icewind1991,
kesselb and
rullzer
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
Member
Author
|
/backport to stable17 |
Member
Author
|
/backport to stable16 |
rullzer
approved these changes
May 25, 2020
icewind1991
approved these changes
May 25, 2020
kesselb
added
4. to release
Before the resources/config/ca-bundle.crt was only used when the list of custom certificates was empty and the instance was not installed. But it should also be used when the list is empty and the instance is installed. This is inverting the logic to stop if the instance is not installed to use the default bundle. And it also does this when the list is empty. Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
bug/noid/do-not-read-cert-from-datadir-by-default
branch
from
f748d1d to
18b0d75
Compare
Member
Author
|
I fixed the tests. They required the |
This was referenced May 25, 2020
Member
|
This one was reverted on the stable branches, but not on master (and now 20). Why so? |
Member
Author
This was referenced Dec 4, 2020
Member
Author
|
Indeed - broken on stable20 as well: #24556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the resources/config/ca-bundle.crt was only used when the list of custom
certificates was empty and the instance was not installed. But it should also
be used when the list is empty and the instance is installed.
This is inverting the logic to stop if the instance is not installed to use the
default bundle. And it also does this when the list is empty.
Noticed while debugging user creation on an instance with object storage.