[stable17] Don't remove last user in ldap group when limit is -1 #21104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
ChristophWurst,
blizzz,
kklem0,
rullzer and
skjnldsv
Member
|
cc @blizzz |
kklem0
approved these changes
May 26, 2020
Contributor
|
The backport version is not removing the old lines, it works but the old lines are useless code. server/apps/user_ldap/lib/Group_LDAP.php Line 842 in 726ec88 |
Signed-off-by: Clement Wong <[email protected]>
blizzz
force-pushed
the
backport/20676/stable17
branch
from
726ec88 to
95a647b
Compare
Member
Yup. Removed them now. No need for them to stick around. |
blizzz
added
the
4. to release
blizzz
approved these changes
May 26, 2020
ChristophWurst
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #20676