use the loginname to verify the old password in user password changes #21106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
rullzer
ChristophWurst
approved these changes
May 26, 2020
Member
|
backports? |
MorrisJobke
approved these changes
May 26, 2020
Member
|
CI fails |
rullzer
approved these changes
May 26, 2020
Member
Author
I'll check later today |
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
Member
Author
|
/backport to stable17 |
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/10809/user-pwd-change-loginname
branch
from
92d1f0e to
653162a
Compare
Member
Author
Ha, there the tests were hidden. Expected them in a different location. Should pass now :) |
MorrisJobke
added
4. to release
This was referenced May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For user driven password changes, the controller was using the uid instead of the login name to verify the current password. The login name must be used instead. While it does not play a matter for local backends, e.g. LDAP environments do suffer and often end fail with misleading "wrong password".
fixes #10809