Skip to content

Simplify text variables from 4 to 2, map -lighter to -maxcontrast #21117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
May 27, 2020
Merged

Simplify text variables from 4 to 2, map -lighter to -maxcontrast #21117

MorrisJobke merged 1 commit into from
May 27, 2020

Conversation

@jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented May 26, 2020

As said in: Fix color-text-maxcontrast not passing WCAG AA #20853

I would say since the values are so similar, we limit the text variables to just color-main-text and color-text-maxcontrast. I would make both "light" and "lighter" map to "color-text-maxcontrast" for compatibility.

Please review @nextcloud/designers

@jancborchardt jancborchardt added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels May 26, 2020
@jancborchardt jancborchardt added this to the Nextcloud 20 milestone May 26, 2020
@jancborchardt jancborchardt mentioned this pull request May 26, 2020
Merged
marcoambrosini
marcoambrosini approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MorrisJobke MorrisJobke merged commit b9222ff into master May 27, 2020
@MorrisJobke MorrisJobke deleted the design/text-variables-simplify branch May 27, 2020 08:50
Rello added a commit to Rello/analytics that referenced this pull request Mar 4, 2024
@Rello
css deprecation nextcloud/server#21117
ec1ac8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. enhancement

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

4 participants

@jancborchardt @MorrisJobke @marcoambrosini