simplify getGroups, fixing wrong chunking logic #21123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagination is taken care of properly in the search logic in Access class Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
rullzer
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
Member
Author
|
/backport to stable17 |
ChristophWurst
approved these changes
May 27, 2020
juliusknorr
approved these changes
May 27, 2020
juliusknorr
added
4. to release
This was referenced May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of
getGroupswas replaced bygetGroupsChunks which was then removed itself.For some reasons we did our pagination logic there on top, basically sabotaging propering pagination logic as we have it in the search methods in the Access class. And in a buggy way. In a case with over 500 groups, only 498 or so were reported. Because two invalid ones where discarded, the old code said: "oh, there is nothing more to fetch", as the received number was less than the requested number of items.
That was containing code back from 2012 that probably just was not updated so far – infamous bitrot.