Do not only catch Exceptions but any Throwable during rmt share delete #21181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a remote share is deleted, we notify the remove instance. This may trigger various error conditions, which we want to catch in order to avoid undeletable shares. The try-catch, however, did only capture exceptions, so things like TypeErrors were not caught and caused the process to fail hard. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
anagromataf,
cp289,
danxuliu,
icewind1991,
johkoenig,
juliusknorr,
nickvergessen and
rullzer
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
Member
Author
|
/backport to stable17 |
juliusknorr
approved these changes
Jun 2, 2020
nickvergessen
approved these changes
Jun 2, 2020
ChristophWurst
added
4. to release
rullzer
approved these changes
Jun 2, 2020
Member
Author
|
Are https://drone.nextcloud.com/nextcloud/server/29418/36/3 and https://drone.nextcloud.com/nextcloud/server/29418/37/3 possibly related to this change? I can't tell. |
Member
Author
|
is the error for both runs. |
cp289
approved these changes
Jun 2, 2020
Member
As far as I know they come from #16035. |
This was referenced Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a remote share is deleted, we notify the remote instance. This may
trigger various error conditions, which we want to catch in order to
avoid undeletable shares. The try-catch, however, did only capture
exceptions, so things like TypeErrors were not caught and caused the
process to fail hard.