[stable19] Fix the Talk verification #21210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabling or disabling Talk verification in mail shares the server expects also a new password to be set. As we always just update one property at a time this means the Talk verification was impossible to activate or deactivate. With this patch, we send the talk option AND the new password. If there is no new password, the Talk option is disabled (in mail shares; in link shares it is possible to enable or disable the video verification without changing the password). When we finally have descriptive text on ActionCheckbox'es we should definitely add some explanatory text for the user. Right now this is as good as it gets. We'll have to backport to 18. Signed-off-by: Christoph Wurst <[email protected]>
backportbot-nextcloud
bot
requested review from
ChristophWurst,
danxuliu,
georgehrke,
juliusknorr,
nickvergessen,
rullzer and
skjnldsv
Member
|
/compile amend / |
ChristophWurst
approved these changes
Jun 3, 2020
When video verification can not be enabled or disabled the previous state is set again in the JavaScript share object. This ensures that the UI will not reflect a misleading state. Signed-off-by: Daniel Calviño Sánchez <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
backport/20938/stable19
branch
from
b79fb6c to
01ccbe6
Compare
JanDragon
approved these changes
Jun 6, 2020
JanDragon
left a comment
JanDragon
left a comment
There was a problem hiding this comment.
Works fine and without any Problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚠️ This backport had conflicts and is incomplete ⚠️ backport of #20938