Skip to content

Init fileinfo for all tabs #21306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Jun 9, 2020
Merged

Init fileinfo for all tabs #21306

rullzer merged 1 commit into from
Jun 9, 2020

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 8, 2020

After #20564

No idea why this works on master, reactivity seems to behave better.
Anyway, it works now™

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews high javascript feature: file sidebar Related to the file sidebar component 18-feedback labels Jun 8, 2020
@skjnldsv skjnldsv added this to the Nextcloud 18.0.6 milestone Jun 8, 2020
@skjnldsv skjnldsv self-assigned this Jun 8, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 8, 2020

/compile amend /

@skjnldsv @npmbuildbot
Init fileinfo for all tabs
366ee97 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/stable18/sidebar-tabs-update branch from c909320 to 366ee97 Compare June 8, 2020 11:03
@rullzer rullzer mentioned this pull request Jun 8, 2020
Closed
@kklem0 kklem0 self-requested a review June 8, 2020 11:13
@kesselb kesselb linked an issue Jun 8, 2020 that may be closed by this pull request
[Updating to 18.0.5.] The document does not display versions, comments, events. (Sidebar) #21239
Closed
kesselb
kesselb approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@go2sh
Copy link
Contributor

go2sh commented Jun 8, 2020

This commit is the reason, why it works on master an stable19. As I said old nextcloud-vue version...

@kklem0
Copy link
Contributor

kklem0 commented Jun 8, 2020 •
edited
Loading

This commit is the reason, why it works on master an stable19. As I said old nextcloud-vue version...

Just to make sure, this commit was also in stable18 as nextcloud-libraries/nextcloud-vue@ee18269, but I'm probably missing something.

go2sh
go2sh approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@go2sh go2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on an freshly checkout instance of the branche and activity app. Fixes both the old issue and my regression. Sorry for that...

@go2sh
Copy link
Contributor

go2sh commented Jun 8, 2020

@clementhk Hmm okay, maybe you are right. I just saw during my debugging, that the watched fileProp function I use, was not part of the actualy fileProp object watcher list and so the loaded fileProp did not propagate to the tabs :(

@rullzer rullzer mentioned this pull request Jun 8, 2020
Merged
1 task
@kklem0
Copy link
Contributor

kklem0 commented Jun 8, 2020

@clementhk Hmm okay, maybe you are right. I just saw during my debugging, that the watched fileProp function I use, was not part of the actualy fileProp object watcher list and so the loaded fileProp did not propagate to the tabs :(

So if we can confirm that stable19/master actually work and don't need porting, we could either just go with this (everything works for me so I guess no harm there) or we could try to find out which commit made stable19/master work and backport it to keep consistency?

@rullzer rullzer merged commit 149d471 into stable18 Jun 9, 2020
@rullzer rullzer deleted the fix/stable18/sidebar-tabs-update branch June 9, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@go2sh go2sh go2sh approved these changes

@kklem0 kklem0 kklem0 approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug feature: file sidebar Related to the file sidebar component high javascript

Projects

None yet

Milestone

Nextcloud 18.0.6

Development

Successfully merging this pull request may close these issues.

[Updating to 18.0.5.] The document does not display versions, comments, events. (Sidebar)

7 participants

@skjnldsv @go2sh @kklem0 @rullzer @juliusknorr @kesselb