Disable Client-Side Monitoring on AWS storage #21406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The S3 client enables this by default and then tries to read `.aws/config`. This causes `open_basedir` restriction related error for some setups. So this patch disables the CSM because it's most likely unused anyway. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
requested review from
FlorentCoppint,
fodinabor,
icewind1991,
juliusknorr,
mabkenar and
rullzer
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
georgehrke
approved these changes
Jun 15, 2020
Member
georgehrke
left a comment
georgehrke
left a comment
There was a problem hiding this comment.
Code looks good, didn't test due to lack of S3 either.
juliusknorr
approved these changes
Jun 15, 2020
Member
|
Did some quick smoke test with minio and still seems to work without issues. |
Contributor
FlorentCoppint
left a comment
FlorentCoppint
left a comment
There was a problem hiding this comment.
Code is good, but I'm using S3 as primary storage and I don't have open_basedir errors.
It seems that "false" is the default option value : https://github.com/aws/aws-sdk-php/blob/master/src/AwsClient.php#L74
icewind1991
approved these changes
Jun 16, 2020
This was referenced Jun 17, 2020
MorrisJobke
pushed a commit
that referenced
this pull request
May 20, 2021
When using S3 storage, we sometimes have open_basedir errors due to aws-sdk-php trying to read ~/.aws/config which is out of open_basedir restrictions. Christoph Wurst already added csm=false config in #21406 but it wasn't enough, we also need to set use_arn_region=false, added in this commit. Signed-off-by: Florent <[email protected]>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
May 25, 2021
When using S3 storage, we sometimes have open_basedir errors due to aws-sdk-php trying to read ~/.aws/config which is out of open_basedir restrictions. Christoph Wurst already added csm=false config in #21406 but it wasn't enough, we also need to set use_arn_region=false, added in this commit. Signed-off-by: Florent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S3 client enables this by default and then tries to read
.aws/config. This causesopen_basedirrestriction related error forsome setups. So this patch disables the CSM because it's most likely
unused anyway.
Ref aws/aws-sdk-php#1659 (comment)
Ref aws/aws-sdk-php#1931