Continue with next app when one errors during register #21463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My patch at #21461 had a little error in that it exits the method when a query exception is encountered during the register step of an app. What we actually want is to continue with the next app and finish the overall registration procedure. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
requested review from
hanzi,
kesselb,
mnheia,
nickvergessen,
rullzer and
srkunze
rullzer
approved these changes
Jun 18, 2020
nickvergessen
approved these changes
Jun 18, 2020
ChristophWurst
added
4. to release
kesselb
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #21461 I overlooked that there is a loop. 🙊
My patch at #21461 had a little error in that it exits the method when a
query exception is encountered during the register step of an app. What
we actually want is to continue with the next app and finish the overall
registration procedure.