Give up after 10 seconds in SCSS timeout #21483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else we keep idling for ages which leads to bad UX Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
requested review from
ChristophWurst,
georgehrke,
juliusknorr,
kesselb,
nickvergessen and
skjnldsv
Contributor
|
#21059 as reference. Change looks good but I still don't know what the while does at all. I mean we never try to aquire the lock again. We are just waiting and hope the variables change in the meantime or the file is now cached (probably by another process). |
georgehrke
approved these changes
Jun 19, 2020
nickvergessen
approved these changes
Jun 19, 2020
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
This was referenced Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Else we keep idling for ages which leads to bad UX
Signed-off-by: Roeland Jago Douma [email protected]