Skip to content

fix #21285 as oneliner #21498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Jul 7, 2020
Merged

fix #21285 as oneliner #21498

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7f053b
Return correct loginname in credentials,
Jun 7, 2020
fa2b111
adapt testGetLoginCredentialsInvalidTokenLoginCredentials() unit test…
Jun 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
adapt testGetLoginCredentialsInvalidTokenLoginCredentials() unit test… 
… to uid != loginname

Signed-off-by: Lionel Elie Mamane <[email protected]>
  • Loading branch information
Lionel Elie Mamane committed Jun 20, 2020
commit fa2b111696a85beae9a1ce4e326b9140c8799231
11 changes: 6 additions & 5 deletions tests/lib/Authentication/LoginCredentials/StoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,8 @@ public function testGetLoginCredentialsInvalidToken() {
}

public function testGetLoginCredentialsInvalidTokenLoginCredentials() {
$uid = 'user987';
$uid = 'id987';
$user = 'user987';
$password = '7389374';

$this->session->expects($this->once())
Expand All @@ -156,11 +157,11 @@ public function testGetLoginCredentialsInvalidTokenLoginCredentials() {
->method('exists')
->with($this->equalTo('login_credentials'))
->willReturn(true);
$this->session->expects($this->once())
$this->session->expects($this->exactly(2))
->method('get')
->with($this->equalTo('login_credentials'))
->willReturn('{"run":true,"uid":"user987","password":"7389374"}');
$expected = new Credentials('user987', 'user987', '7389374');
->withConsecutive(['login_credentials'], ['loginname'])
->willReturnOnConsecutiveCalls('{"run":true,"uid":"id987","password":"7389374"}', $user);
$expected = new Credentials($uid, $user, $password);

$actual = $this->store->getLoginCredentials();

Expand Down