comment was wrong, block is needed nevertheless #21565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
requested review from
Dennis1993,
juliusknorr,
kesselb,
rullzer and
splitt3r
Member
Author
|
/backport to stable19 |
rullzer
approved these changes
Jun 24, 2020
juliusknorr
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. https://github.com/nextcloud/server/pull/21108/files/15008a17984c99cbf94d13b39e8f501bbe6b5698#r441516537
@hashworks thanks for pointing it out. I just verified it again.
Also backporting it, to have it accurately in this branch, too, not that someone is coimng to ideas :)