Skip to content

[stable19] Fix share permission checkboxes enabled when permissions can not be set #21574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 5 commits into from
Jul 6, 2020
Merged

[stable19] Fix share permission checkboxes enabled when permissions can not be set #21574

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e815b13
Generalize functions to get locators for share permission checkboxes
danxuliu Jun 11, 2020
ae3af29
Add acceptance test for sharing a file without edit permission
danxuliu Jun 11, 2020
244a7e1
Add acceptance test for sharing a folder without create permission
danxuliu Jun 11, 2020
4401cd2
Add acceptance test for disabling create permission after sharing
danxuliu Jun 11, 2020
87be931
Fix share permission checkboxes enabled when permissions can not be set
danxuliu Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add acceptance test for disabling create permission after sharing 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu @backportbot
danxuliu authored and backportbot[bot] committed Jun 24, 2020
commit 4401cd27177c927341a65c512a032173ce08632a
43 changes: 43 additions & 0 deletions tests/acceptance/features/app-files-sharing.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,3 +334,46 @@ Feature: app-files-sharing
Then I see that the file is shared with "user1"
And I see that "user1" can not create in the share
And I see that "user1" can not be allowed to create in the share

Scenario: sharee can revoke create permission from reshare after the sharer disabled it
Given I act as John
And I am logged in as the admin
And I act as Jane
And I am logged in
And I act as Jim
And I am logged in as "user1"
And I act as John
And I create a new folder named "Shared folder"
And I see that the file list contains a file named "Shared folder"
And I share "Shared folder" with "user0"
And I see that the file is shared with "user0"
And I act as Jane
# The Files app is open again to reload the file list
And I open the Files app
And I share "Shared folder" with "user1"
And I see that the file is shared with "user1"
And I act as John
And I set the share with "user0" as not creatable
And I see that "user0" can not create in the share
And I act as Jim
# The Files app is open again to reload the file list
And I open the Files app
And I enter in the folder named "Shared folder"
# Creation is still allowed in already created reshares
And I create a new folder named "Subfolder"
And I see that the file list contains a file named "Subfolder"
When I act as Jane
# The Files app is open again to reload the file list
And I open the Files app
And I open the details view for "Shared folder"
And I see that the details view is open
And I open the "Sharing" tab in the details view
And I see that the "Sharing" tab in the details view is eventually loaded
And I set the share with "user1" as not creatable
Then I see that "user1" can not create in the share
And I see that "user1" can not be allowed to create in the share
And I act as Jim
# The Files app is open again to reload the file list
And I open the Files app
And I enter in the folder named "Shared folder"
And I see that it is not possible to create new files