Log usages of the deprecated app.php file #21632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
kesselb
approved these changes
Jun 30, 2020
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
Mind to also log the app path? Makes it easier for setups with multiple apps directories.
Member
Author
But the app may only exist once, right? So it's unambiguous as you know the app's ID. |
Contributor
|
#21613 to add a recent one. Mostly it's a combination of a non writeable apps directory and shipped apps leading to such weird states. |
rullzer
approved these changes
Jun 30, 2020
kesselb
added
4. to release
Member
Author
|
Erm …
|
Member
Author
|
so … revert it is, I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #20865.
This will hopefully get more dev's attention on the deprecation if they don't read the upgrade docs.
I suggest to only add this for 21 so 20 can still handle the old apps and the warning starts later. We can even raise the log level to warn in 22.