Skip to content

Improve error reporting on sharing errors #21748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jul 13, 2020
Merged

Improve error reporting on sharing errors #21748

nickvergessen merged 1 commit into from
Jul 13, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 8, 2020 •
edited
Loading

Steps

  1. Enable password policy app
  2. Create a public link
  3. Set link share password to 123456

Fix #20179

Before After
Bildschirmfoto von 2020-07-08 11-28-24 Bildschirmfoto von 2020-07-08 11-25-49

@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Jul 8, 2020
@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 8, 2020

/backport to stable19

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 8, 2020

/backport to stable18

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 8, 2020

/backport to stable17

@nickvergessen nickvergessen merged commit d31f525 into master Jul 13, 2020
@nickvergessen nickvergessen deleted the bugfix/noid/improve-error-reporting-with-sharing branch July 13, 2020 09:55
This was referenced Jul 13, 2020
Merged
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 13, 2020

The backport to stable17 failed. Please do this backport manually.

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 15, 2020

17 is completely different it seems.

@kesselb kesselb mentioned this pull request Sep 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: sharing

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

password policy error not shown correctly

4 participants

@nickvergessen @ChristophWurst @skjnldsv