Skip to content

Use IBootstrap for the app theming #21818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jul 24, 2020
Merged

Use IBootstrap for the app theming #21818

MorrisJobke merged 1 commit into from
Jul 24, 2020

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Jul 13, 2020 •
edited
Loading

@MorrisJobke MorrisJobke added this to the Nextcloud 20 milestone Jul 13, 2020
nickvergessen
nickvergessen reviewed Jul 13, 2020
View reviewed changes
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/theming-bootstrap branch from b688fcd to 0b6db3c Compare July 13, 2020 20:11
MorrisJobke
MorrisJobke commented Jul 13, 2020
View reviewed changes
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/theming-bootstrap branch from 0b6db3c to 3ed94d5 Compare July 13, 2020 20:13
juliusknorr
juliusknorr reviewed Jul 13, 2020
View reviewed changes
@MorrisJobke MorrisJobke self-assigned this Jul 13, 2020
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 13, 2020
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/theming-bootstrap branch from 3ed94d5 to e80c72d Compare July 15, 2020 19:25
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 15, 2020
@MorrisJobke MorrisJobke removed their assignment Jul 15, 2020
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Jul 15, 2020

Ready for review now 🚀

nickvergessen
nickvergessen reviewed Jul 16, 2020
View reviewed changes
juliusknorr
juliusknorr reviewed Jul 20, 2020
View reviewed changes
@MorrisJobke MorrisJobke added 1. to develop Accepted and waiting to be taken care of and removed 3. to review Waiting for reviews labels Jul 23, 2020
@juliusknorr juliusknorr mentioned this pull request Jul 24, 2020
Merged
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/theming-bootstrap branch from e80c72d to 340cd81 Compare July 24, 2020 10:23
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Jul 24, 2020

Pushed, tested and works - thanks @juliushaertl 🚀

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jul 24, 2020
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Jul 24, 2020

Ready for a final review :)

@faily-bot
Copy link

faily-bot bot commented Jul 24, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31075: failure

integration-auth

  • build/integration/features/auth.feature:70
Show full log 
  Scenario: using OCS anonymously                                                    # /drone/src/build/integration/features/auth.feature:70
[Fri Jul 24 10:36:42 2020] 127.0.0.1:41582 [404]: /ocs/v2.php/cloud/users/user0
[Fri Jul 24 10:36:43 2020] 127.0.0.1:41604 [200]: /ocs/v1.php/cloud/users
[Fri Jul 24 10:36:43 2020] 127.0.0.1:41646 [200]: /ocs/v1.php/cloud/users/user0
[Fri Jul 24 10:36:43 2020] 127.0.0.1:41670 [200]: /ocs/v2.php/cloud/users/user0
[Fri Jul 24 10:36:43 2020] 127.0.0.1:41686 [200]: /login
[Fri Jul 24 10:36:43 2020] 127.0.0.1:41690 [303]: /login
[Fri Jul 24 10:36:44 2020] 127.0.0.1:41720 [200]: /index.php/apps/files/
[Fri Jul 24 10:36:44 2020] 127.0.0.1:41722 [200]: /index.php/settings/personal/authtokens
[Fri Jul 24 10:36:44 2020] 127.0.0.1:41730 [200]: /index.php/settings/personal/authtokens/56
[Fri Jul 24 10:36:44 2020] 127.0.0.1:41734 [303]: /login
[Fri Jul 24 10:36:44 2020] 127.0.0.1:41736 [200]: /index.php/apps/files/
[Fri Jul 24 10:36:44 2020] 127.0.0.1:41742 [303]: /login
[Fri Jul 24 10:36:44 2020] 127.0.0.1:41768 [200]: /index.php/apps/files/
[Fri Jul 24 10:36:44 2020] 127.0.0.1:41770 [200]: /index.php/settings/personal/authtokens
[Fri Jul 24 10:36:44 2020] TypeError: Argument 11 passed to OCA\Files_Sharing\External\Manager::__construct() must be of the type string, null given, called in /drone/src/apps/files_sharing/lib/AppInfo/Application.php on line 98 at /drone/src/apps/files_sharing/lib/External/Manager.php#91
[Fri Jul 24 10:36:44 2020] 127.0.0.1:41780 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares
    When requesting "/ocs/v1.php/apps/files_sharing/api/v1/remote_shares" with "GET" # FeatureContext::requestingWith()
    Then the OCS status code should be "997"                                         # FeatureContext::theOCSStatusCodeShouldBe()
      Notice: Trying to get property 'meta' of non-object in /drone/src/build/integration/features/bootstrap/BasicStructure.php line 153
[Fri Jul 24 10:36:44 2020] 127.0.0.1:41782 [200]: /ocs/v1.php/cloud/users/user0
[Fri Jul 24 10:36:45 2020] 127.0.0.1:41822 [404]: /ocs/v2.php/cloud/users/user0
[Fri Jul 24 10:36:45 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Jul 24 10:36:45 2020] 127.0.0.1:41842 [401]: /remote.php/webdav/myFileToComment.txt
[Fri Jul 24 10:36:45 2020] 127.0.0.1:41844 [207]: /remote.php/dav/systemtags/
[Fri Jul 24 10:36:45 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Jul 24 10:36:45 2020] 127.0.0.1:41878 [401]: /remote.php/webdav/myFileToTag.txt
[Fri Jul 24 10:36:45 2020] 127.0.0.1:41880 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Fri Jul 24 10:36:46 2020] 127.0.0.1:41908 [404]: /remote.php/dav/calendars/admin/MyCalendar

@MorrisJobke MorrisJobke merged commit 6318721 into master Jul 24, 2020
@MorrisJobke MorrisJobke deleted the techdebt/noid/theming-bootstrap branch July 24, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr left review comments

@rullzer rullzer rullzer approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

6 participants

@MorrisJobke @rullzer @nickvergessen @ChristophWurst @juliusknorr